sort: on 32 bits, decrease the buf max size #10290
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
ChrisDryden
reviewed
Jan 17, 2026
| // reasonably large chunks for typical workloads. | ||
| const MIN_AUTOMATIC_BUF_SIZE: usize = 512 * 1024; // 512 KiB | ||
| const FALLBACK_AUTOMATIC_BUF_SIZE: usize = 32 * 1024 * 1024; // 32 MiB | ||
| // On 32-bit systems, use a smaller max buffer (256 MiB) to avoid allocation |
Collaborator
There was a problem hiding this comment.
To confirm my understanding, this is only a temporary fix right? I was trying to replicate the behaviour in GNU and it appears they have a mechanism to determine the available memory and gracefully fallback to smaller and smaller amounts that I was not able to get an allocation failure. I'm thinking this would be a good band-aid solution for now but would be good to add a TODO or keep the issue with the description that we're missing some compatibility when it comes to the memory allocation fallbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See
https://bugs.launchpad.net/ubuntu/+source/rust-coreutils/+bug/2137562