Skip to content

fix(cp): continue traversal on NotFound error #10301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nekluu wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix(cp): continue traversal on NotFound error #10301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/uu/cp/src/copydir.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,16 @@ fn copy_direntry(
),
));
}
Copy link
Collaborator

@Ecordonnier Ecordonnier Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the TODO and the comment that this function should terminate if there is any kind of error except certain errors seems wrong to me. This does not match the behavior of GNU coreutils and the POSIX specification.

This was added originally in b89e8e5 / #3973

I think the function should continue on any errors to match the behavior of GNU coreutils, or am I missing something?

See the specification:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/cp.html
""When a failure occurs during the copying of a file hierarchy, cp is required to attempt to copy files that are on the same level in the hierarchy or above the file where the failure occurred. It is unspecified if cp shall attempt to copy files below the file where the failure occurred (which cannot succeed in any case)."

And multiple places in the DESCRIPTION say:

"cp shall write a diagnostic message to standard error, do nothing more with source_file, and go on to any remaining files.""

CpError::IoErrContext(e, _) if e.kind() == io::ErrorKind::NotFound => {
show!(uio_error!(
e,
"{}",
translate!(
"cp-error-cannot-stat-no-such-file",
Copy link
Collaborator

@Ecordonnier Ecordonnier Jan 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"cp-error-cannot-stat-no-such-file" is not defined in the translation file. It would need to be added (see truncate as example):

asteba@asteba-MS-7C75:~/dev/coreutils/src/uu$ rg "cannot-stat-no-such-file" .
./cp/src/copydir.rs
326:                                "cp-error-cannot-stat-no-such-file",

./truncate/locales/fr-FR.ftl
33:truncate-error-cannot-stat-no-such-file = impossible d'obtenir les informations de { $filename } : Aucun fichier ou répertoire de ce type

./truncate/locales/en-US.ftl
33:truncate-error-cannot-stat-no-such-file = cannot stat { $filename }: No such file or directory

./truncate/src/truncate.rs
253:                    translate!("truncate-error-cannot-stat-no-such-file", "filename" => reference_path.quote()),

"source" => entry.source_relative.quote()
),
));
}
e => return Err(e),
}
}
Expand Down
Loading