Skip to content

Unexpand use buffered reads + tests#10831

Open
cerdelen wants to merge 2 commits intouutils:mainfrom
cerdelen:unexpand_buffer
Open

Unexpand use buffered reads + tests#10831
cerdelen wants to merge 2 commits intouutils:mainfrom
cerdelen:unexpand_buffer

Conversation

@cerdelen
Copy link
Contributor

@cerdelen cerdelen commented Feb 8, 2026

New PR to fix issues after revert of #10798

Fix: #10698

@sylvestre
Copy link
Contributor

do we need that many tests ? thanks

@cerdelen
Copy link
Contributor Author

cerdelen commented Feb 8, 2026

Every test is a different edge case around the chunking process. I thought rather have a few more than a few too little.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

GNU testsuite comparison:

Congrats! The gnu test tests/tail/tail-n0f is now passing!

@sylvestre
Copy link
Contributor

yeah my point was that there is some duplications in the tests and they might be merged with a loop with different args / expectations

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 8, 2026

Merging this PR will improve performance by 58.43%

⚡ 2 improved benchmarks
✅ 282 untouched benchmarks
⏩ 38 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation unexpand_many_lines[100000] 300.6 ms 189.7 ms +58.4%
Simulation unexpand_large_file[10] 630.1 ms 397.7 ms +58.43%

Comparing cerdelen:unexpand_buffer (d4601f0) with main (194d980)

Open in CodSpeed

Footnotes

  1. 38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unexpand: unexpand /dev/zero panic

2 participants