Skip to content

introduce static mut IS_POSIXLY_CORRECT#11939

Draft
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:static-posixly-correct3
Draft

introduce static mut IS_POSIXLY_CORRECT#11939
xtqqczze wants to merge 1 commit intouutils:mainfrom
xtqqczze:static-posixly-correct3

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

No description provided.

@xtqqczze xtqqczze force-pushed the static-posixly-correct3 branch 2 times, most recently from 9cc75ba to 5f3a2aa Compare April 22, 2026 00:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

GNU testsuite comparison:

GNU test failed: tests/tail/retry. tests/tail/retry is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/symlink (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@xtqqczze xtqqczze force-pushed the static-posixly-correct3 branch from 5f3a2aa to 067520d Compare April 22, 2026 13:57
@RenjiSann
Copy link
Copy Markdown
Collaborator

Why would you introduce so much unsafe here ? Is it motivated by a significant gain in performance ?

@xtqqczze xtqqczze force-pushed the static-posixly-correct3 branch from 067520d to de2ca92 Compare April 23, 2026 20:06
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 23, 2026

Merging this PR will degrade performance by 23.82%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 288 untouched benchmarks
⏩ 66 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Memory cp_recursive_deep_tree[(120, 4)] 532.7 KB 699.2 KB -23.82%

Comparing xtqqczze:static-posixly-correct3 (6dc2b99) with main (896c685)

Open in CodSpeed

Footnotes

  1. 66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@xtqqczze xtqqczze changed the title cp: introduce static mut IS_POSIXLY_CORRECT introduce static mut IS_POSIXLY_CORRECT Apr 23, 2026
@xtqqczze xtqqczze force-pushed the static-posixly-correct3 branch from de2ca92 to 6dc2b99 Compare April 23, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants