Skip to content

numfmt: reject %f values too large to format exactly#12012

Open
pocopepe wants to merge 1 commit intouutils:mainfrom
pocopepe:11936
Open

numfmt: reject %f values too large to format exactly#12012
pocopepe wants to merge 1 commit intouutils:mainfrom
pocopepe:11936

Conversation

@pocopepe
Copy link
Copy Markdown
Contributor

Fixes #11936

%N.Mf was silently lossy for very large ints via the f64 path. Now bails out when the value would need 20+ digits to print, like GNU does.

@github-actions
Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/basenc/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/pr/bounded-memory is now passing!
Congrats! The gnu test tests/unexpand/bounded-memory is now passing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numfmt: --format=%N.Mf silently prints lossy output for very large integers (GNU rejects)

1 participant