Skip to content

fix(wasi): date clock resolution and system datetime support - #13687

Open
eduardomourar wants to merge 1 commit into
uutils:mainfrom
eduardomourar:wasi-date-fixes
Open

fix(wasi): date clock resolution and system datetime support#13687
eduardomourar wants to merge 1 commit into
uutils:mainfrom
eduardomourar:wasi-date-fixes

Conversation

@eduardomourar

Copy link
Copy Markdown
Contributor

date implements get_clock_resolution via libc::clock_getres (rustix's excludes WASI) and set_system_datetime for WASI, the latter reporting "not supported" since the sandbox has no wall-clock-set syscall.

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@codspeed-hq

codspeed-hq Bot commented Aug 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 10 untouched benchmarks
⏩ 408 skipped benchmarks1


Comparing eduardomourar:wasi-date-fixes (7cc713f) with main (13deb96)2

Open in CodSpeed

Footnotes

  1. 408 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (6cdc202) during the generation of this report, so 13deb96 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@eduardomourar
eduardomourar force-pushed the wasi-date-fixes branch 2 times, most recently from 088a4d0 to d2b7ca2 Compare August 11, 2026 18:20
@eduardomourar

Copy link
Copy Markdown
Contributor Author

@sylvestre, this one is ready (now with proper testing in place).

@eduardomourar
eduardomourar force-pushed the wasi-date-fixes branch 3 times, most recently from 3527d4f to 3c980e5 Compare September 7, 2026 09:19
@sylvestre
sylvestre enabled auto-merge (rebase) September 7, 2026 09:23
auto-merge was automatically disabled September 7, 2026 15:24

Head branch was pushed to by a user without write access

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

Binary size comparison:

Individual binary size comparison VS main (threshold: >=5% AND >=4 KB).

Total size of compared binaries: 153.09 MB (+912 KB, +0.59%)

Significant per-binary changes:
  expr     2.76 MB ->    3.65 MB  (+908 KB, +32.11%)

date implements get_clock_resolution via libc::clock_getres (rustix's
excludes WASI) and set_system_datetime for WASI, the latter reporting
"not supported" since the sandbox has no wall-clock-set syscall.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant