Skip to content

Conversation

@sylvestre
Copy link
Contributor

@github-actions
Copy link

github-actions bot commented Dec 3, 2024

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre requested review from BenWiederhake and cakebaker and removed request for cakebaker December 4, 2024 09:00
@cakebaker
Copy link
Contributor

Hm, is this PR supposed to fix all warnings from the map_unwrap_or lint? When I run cargo clippy -- -W clippy::map_unwrap_or on the main branch I get warnings in utils like ls and sort and there are no changes to those utils in this PR.

@sylvestre
Copy link
Contributor Author

it fixed the issues that I saw :(
We can fix the rest in a different PR

Copy link
Contributor

@cakebaker cakebaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though I would move the changes made to split and tac to its own commit because they are unrelated to the map_unwrap_or lint. They seem to fix warnings from the needless_as_bytes lint.

@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/misc/usage_vs_getopt. tests/misc/usage_vs_getopt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/basenc/basenc is no longer failing!
Skipping an intermittent issue tests/tail/inotify-dir-recreate (passes in this run but fails in the 'main' branch)

@cakebaker cakebaker merged commit 02eb2c0 into uutils:main Dec 18, 2024
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants