Iterative loop for ls recursive directory search by kimono-koans · Pull Request #8728 · uutils/coreutils

kimono-koans · 2025-09-24T00:45:33Z

Would resolve: #8725

codspeed-hq · 2025-09-24T01:04:04Z

CodSpeed Performance Report

Merging #8728 will degrade performance by 6.93%

_{Comparing kimono-koans:recursive_loop (a81624d) with main (6c5fae7)}

Summary

⚡ 1 improvement
❌ 3 regressions
✅ 123 untouched
⏩ 6 skipped¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`ls_recursive_deep_tree[(200, 2)]`	2.2 ms	1.8 ms	+23.04%
❌	`ls_recursive_long_all_wide_tree[(15000, 1500)]`	142.9 ms	153.6 ms	-6.93%
❌	`ls_recursive_long_all_balanced_tree[(6, 4, 15)]`	134.5 ms	141.3 ms	-4.85%
❌	`ls_recursive_long_all_mixed_tree`	2.9 ms	3.1 ms	-6.36%

6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-09-24T01:06:33Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-24T01:38:17Z

GNU testsuite comparison:

Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-24T02:30:49Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-24T03:09:17Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-24T04:12:14Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-24T05:09:42Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-09-24T08:06:04Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/stdbuf (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/timeout/timeout (passes in this run but fails in the 'main' branch)

src/uu/ls/src/ls.rs

…utils into recursive_loop

github-actions · 2025-09-24T16:34:16Z

GNU testsuite comparison:

GNU test failed: tests/tail/overlay-headers. tests/tail/overlay-headers is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)

github-actions · 2025-09-24T18:14:14Z

GNU testsuite comparison:

GNU test failed: tests/tail/overlay-headers. tests/tail/overlay-headers is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2025-10-01T19:44:48Z

GNU testsuite comparison:

GNU test failed: tests/ls/follow-slink. tests/ls/follow-slink is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!

github-actions · 2025-10-01T21:47:06Z

GNU testsuite comparison:

GNU test failed: tests/ls/capability. tests/ls/capability is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/ls/follow-slink. tests/ls/follow-slink is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-10-01T23:03:11Z

GNU testsuite comparison:

GNU test failed: tests/ls/follow-slink. tests/ls/follow-slink is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-10-02T00:26:01Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

sylvestre · 2025-10-06T20:26:37Z

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

it is a regression, sorry

kimono-koans · 2025-10-06T21:50:14Z

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

it is a regression, sorry

It's not a very good GNU test unfortunately. It seems purely about some internal GNU implementation detail which is years outdated. Because this branch works displaying colors when a file has a capability and ca=1 is set in LS_COLORS.

See the test below:

touch file || framework_failure_

setcap 'cap_net_bind_service=ep' file ||
  skip_ "setcap doesn't work"

LS_COLORS=ca=1; export LS_COLORS
strace -e capget ls --color=always > /dev/null 2> out || fail=1
$EGREP 'capget\(' out || skip_ "your ls doesn't call capget"

Now -- setcap and getcap are packaged together, and can you guess how getcap obtains the capability? Like my branch, it also checks the xattr of the file.

getxattr("./file", "security.capability", "\1\0\0\2\0\4\0\0\0\0\0\0\0\0\0\0\0\0\0", 24) = 20

Right now, capget, the syscall, is AFAICT only for obtaining a thread's capabilities, not a files, so I really have no idea what GNU is doing here. This test works without calling capget, and has AFAICT for every kernel since 2.6.24. Prior to 2.6.24, there didn't seem to be any VFS support (read: any cap support for files).

See: https://man7.org/linux/man-pages/man2/capget.2.html

Also, IMHO, in no world, was this ever passing for uutils, because, in no world, was any code running which called capget in main/master.

github-actions · 2025-10-31T22:20:53Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-11-02T20:51:43Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

sylvestre

still need love to fix

Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

github-actions · 2025-12-26T00:59:48Z

GNU testsuite comparison:

Congrats! The gnu test tests/ls/stat-free-symlinks is no longer failing!
Note: The gnu test tests/ls/no-cap is now being skipped but was previously passing.

sylvestre · 2026-01-13T21:14:22Z

i am sorry but it needs to be rebased :)

sylvestre · 2026-01-18T17:11:23Z

@kimono-koans ping ? :)

oech3 · 2026-03-08T06:17:58Z

@kimono-koans Any progress?

kimono-koans added 3 commits September 23, 2025 19:26

Initial commit

753f8b0

Closer

3d3d9de

Get queue order correct

8393d5f

Use one contains, instead of insert and remove

b8bee00

kimono-koans added 2 commits September 23, 2025 21:02

No need for HashSet

fe259c4

Cleanup

7c2c27b

Merge branch 'main' into recursive_loop

fa68904

Reduce syscalls via retained metadata

da4e85d

kimono-koans added 4 commits September 23, 2025 23:29

Fix lints

aba3997

Fix lints

09cbb15

Cleanup

c1304de

Cleanup

a90d73c

Merge branch 'main' into recursive_loop

d096b8b

RenjiSann reviewed Sep 24, 2025

View reviewed changes

src/uu/ls/src/ls.rs Outdated Show resolved Hide resolved

kimono-koans added 2 commits September 24, 2025 11:12

Use "stack" instead of queue

11f1739

Merge branch 'recursive_loop' of https://github.com/kimono-koans/core…

05990a3

…utils into recursive_loop

kimono-koans added 4 commits September 24, 2025 12:19

More likely inode is different than device, allows early bailout

08e2e27

Use single mut vector instead of appending new vectors to stack

451b4a5

Fix bug re: recursive symlinks

fc70e39

Cleanup

78a80c2

Merge branch 'main' into recursive_loop

f9f91fc

Fix GNU test, add back correctness changes

f1dc38b

kimono-koans added 3 commits October 1, 2025 17:21

Fix cap test

0409f0a

Fix GNU test

64dcdbd

Fix the fix

70c329d

kimono-koans added 2 commits October 1, 2025 18:46

FIx GNU test

acf659b

Keeping the windows behavior, as is, conflicts with a GNU test

5cacbaf

kimono-koans marked this pull request as ready for review October 2, 2025 01:34

kimono-koans marked this pull request as draft October 2, 2025 15:50

kimono-koans marked this pull request as ready for review October 4, 2025 01:49

kimono-koans added 3 commits October 22, 2025 18:06

Fix path resolution for links

d313ee3

Make the initial entries stack larger

db2f342

Merge branch 'main' into recursive_loop

42ab3bb

Merge branch 'main' into recursive_loop

a62668e

ChrisDryden mentioned this pull request Dec 24, 2025

GNU coreutils 9.9: Detailed Test report 12/19 #9729

Closed

sylvestre requested changes Dec 26, 2025

View reviewed changes

Merge branch 'main' into recursive_loop

a81624d

ChrisDryden mentioned this pull request Jan 20, 2026

GNU coreutils 9.9: Detailed Test report 01/20 #10390

Open

Uh oh!

Conversation

kimono-koans commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8728 will degrade performance by 6.93%

Summary

Benchmarks breakdown

Footnotes

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

sylvestre commented Oct 6, 2025

Uh oh!

kimono-koans commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

sylvestre left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

sylvestre commented Jan 13, 2026

Uh oh!

sylvestre commented Jan 18, 2026

Uh oh!

oech3 commented Mar 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kimono-koans commented Sep 24, 2025 •

edited

Loading

codspeed-hq bot commented Sep 24, 2025 •

edited

Loading

kimono-koans commented Oct 6, 2025 •

edited

Loading