cksum: Add SHA3/SHAKE support by naoNao89 · Pull Request #8948 · uutils/coreutils

naoNao89 · 2025-10-18T03:54:59Z

Add comprehensive tests for SHA3/SHAKE algorithm support

This PR adds comprehensive test coverage for SHA3 and SHAKE algorithms with the --length parameter.

The SHA3/SHAKE implementation was already merged into main. This PR ensures the algorithms are properly tested with various length parameters and edge cases.

Fixes #8933 (test coverage aspect)

github-actions · 2025-10-18T04:15:02Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

sylvestre · 2025-10-18T09:10:41Z

Could you please add tests to make sure we don't regress in the future? Thanks

src/uu/cksum/src/cksum.rs

github-actions · 2025-10-20T00:29:58Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

src/uucore/src/lib/features/checksum.rs

github-actions · 2025-10-21T05:06:45Z

GNU testsuite comparison:

Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

sylvestre · 2025-10-21T11:34:44Z

please move the --debug implementation in a different PR

naoNao89 · 2025-10-21T11:47:51Z

sr, i missed pushing the commit from 8949 to 8948 🤡

github-actions · 2025-10-21T11:58:18Z

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/cksum/cksum is no longer failing!

sylvestre

still need --debug move away

codspeed-hq · 2025-10-30T05:44:11Z

CodSpeed Performance Report

Merging #8948 will not alter performance

_{Comparing naoNao89:fix-cksum-sha3-debug-8933 (3583fd9) with main (8c10759)}

Summary

✅ 127 untouched
⏩ 6 skipped¹

6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-10-30T06:05:35Z

GNU testsuite comparison:

GNU test failed: tests/cksum/cksum-base64. tests/cksum/cksum-base64 is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

github-actions · 2025-10-30T07:13:26Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-10-31T10:39:17Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-10-31T12:33:01Z

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

tests/by-util/test_cksum.rs

cakebaker · 2025-10-31T15:38:02Z

tests/by-util/test_cksum.rs

 }

+#[test]
+fn test_sha3_with_length() {


This functionality is already tested by test_sha3_single_file.

tests/by-util/test_cksum.rs

@cakebaker

…ack) - Remove test_sha3_with_length() - redundant with test_sha3_single_file() - Remove test_sha3_invalid_length() - redundant with test_sha_length_invalid() and test_sha_missing_length() - Remove test_sha3_untagged() - redundant with test_untagged_sha3_single_file() - Keep test_sha3_base64_output() - provides unique coverage for base64 output with SHA3 Addresses code review feedback from @cakebaker (Oct 31) on PR uutils#8948. All 134 tests pass with no regressions.

github-actions · 2025-11-03T04:48:29Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-03T05:30:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@cakebaker

This commit consolidates all changes for SHA3/SHAKE algorithm support: Features: - Add SHA3 and SHAKE algorithm support to cksum - Support --length parameter for SHA3 (224, 256, 384, 512 bits) - Support --length parameter for SHAKE (any length) - Add base64 output support for SHA3/SHAKE Tests: - Add comprehensive test coverage for SHA3/SHAKE with various lengths - Add tests for base64 output format - Add tests for error cases (invalid lengths, missing length parameter) - Remove redundant test coverage Localization: - Update English and French locale files with SHA3/SHAKE descriptions Fixes PR uutils#8948 code review feedback from @cakebaker, @sylvestre, and @evilpie. All 134 tests pass with no regressions.

github-actions · 2025-11-03T06:44:54Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@cakebaker

This commit consolidates all changes for SHA3/SHAKE algorithm support: Features: - Add SHA3 and SHAKE algorithm support to cksum - Support --length parameter for SHA3 (224, 256, 384, 512 bits) - Support --length parameter for SHAKE (any length) - Add base64 output support for SHA3/SHAKE - Add --debug flag (no-op matching GNU behavior) Tests: - Add comprehensive test coverage for SHA3/SHAKE with various lengths - Add tests for base64 output format - Add tests for error cases (invalid lengths, missing length parameter) - Remove redundant test coverage Localization: - Update English and French locale files with SHA3/SHAKE descriptions Fixes PR uutils#8948 code review feedback from @cakebaker, @sylvestre, and @evilpie. All 134 tests pass with no regressions.

github-actions · 2025-11-03T07:18:08Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-07T11:20:23Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

sylvestre · 2025-12-05T21:39:58Z

@naoNao89 do you want to still land this? thanks

naoNao89 · 2025-12-06T06:34:58Z

am here

github-actions · 2025-12-06T08:44:42Z

GNU testsuite comparison:

Congrats! The gnu test tests/du/files0-from is no longer failing!

oech3 · 2025-12-26T15:55:14Z

Is this PR still active?

@cakebaker

This commit consolidates all changes for SHA3/SHAKE algorithm support: Features: - Add SHA3 and SHAKE algorithm support to cksum - Support --length parameter for SHA3 (224, 256, 384, 512 bits) - Support --length parameter for SHAKE (any length) - Add base64 output support for SHA3/SHAKE - Add --debug flag (no-op matching GNU behavior) Tests: - Add comprehensive test coverage for SHA3/SHAKE with various lengths - Add tests for base64 output format - Add tests for error cases (invalid lengths, missing length parameter) - Remove redundant test coverage Localization: - Update English and French locale files with SHA3/SHAKE descriptions Fixes PR uutils#8948 code review feedback from @cakebaker, @sylvestre, and @evilpie. All 134 tests pass with no regressions.

naoNao89 · 2025-12-27T20:11:54Z

😴

github-actions · 2025-12-27T20:27:33Z

GNU testsuite comparison:

GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?

@cakebaker

This commit consolidates all changes for SHA3/SHAKE algorithm support: Features: - Add SHA3 and SHAKE algorithm support to cksum - Support --length parameter for SHA3 (224, 256, 384, 512 bits) - Support --length parameter for SHAKE (any length) - Add base64 output support for SHA3/SHAKE - Add --debug flag (no-op matching GNU behavior) Tests: - Add comprehensive test coverage for SHA3/SHAKE with various lengths - Add tests for base64 output format - Add tests for error cases (invalid lengths, missing length parameter) - Remove redundant test coverage Localization: - Update English and French locale files with SHA3/SHAKE descriptions Fixes PR uutils#8948 code review feedback from @cakebaker, @sylvestre, and @evilpie. All 134 tests pass with no regressions.

github-actions · 2025-12-29T08:52:53Z

GNU testsuite comparison:

Note: The gnu test tests/id/smack was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-no-root was skipped on 'main' but is now failing.
Note: The gnu test tests/mkdir/smack-root was skipped on 'main' but is now failing.

@cakebaker

This commit consolidates all changes for SHA3/SHAKE algorithm support: Features: - Add SHA3 and SHAKE algorithm support to cksum - Support --length parameter for SHA3 (224, 256, 384, 512 bits) - Support --length parameter for SHAKE (any length) - Add base64 output support for SHA3/SHAKE - Add --debug flag (no-op matching GNU behavior) Tests: - Add comprehensive test coverage for SHA3/SHAKE with various lengths - Add tests for base64 output format - Add tests for error cases (invalid lengths, missing length parameter) - Remove redundant test coverage Localization: - Update English and French locale files with SHA3/SHAKE descriptions Fixes PR uutils#8948 code review feedback from @cakebaker, @sylvestre, and @evilpie. All 134 tests pass with no regressions.

cakebaker · 2026-01-02T08:31:27Z

Closing this PR as all tests already exist. Thanks anyway.

evilpie reviewed Oct 18, 2025

View reviewed changes

src/uu/cksum/src/cksum.rs Outdated Show resolved Hide resolved

sylvestre reviewed Oct 19, 2025

View reviewed changes

src/uu/cksum/src/cksum.rs Outdated Show resolved Hide resolved

sylvestre reviewed Oct 20, 2025

View reviewed changes

src/uucore/src/lib/features/checksum.rs Outdated Show resolved Hide resolved

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from 08769f4 to cbb156c Compare October 21, 2025 11:33

sylvestre requested changes Oct 26, 2025

View reviewed changes

naoNao89 mentioned this pull request Oct 30, 2025

Add --debug flag to cksum #9088

Merged

naoNao89 closed this Oct 30, 2025

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from 9016b78 to 514291d Compare October 30, 2025 05:31

naoNao89 reopened this Oct 30, 2025

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from c177dec to d2ee583 Compare October 30, 2025 05:58

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch 4 times, most recently from 3a9e52b to 6b1cf16 Compare October 30, 2025 06:51

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch 2 times, most recently from dcb966d to fd5840a Compare October 31, 2025 12:09

cakebaker reviewed Oct 31, 2025

View reviewed changes

tests/by-util/test_cksum.rs Show resolved Hide resolved

cakebaker reviewed Oct 31, 2025

View reviewed changes

tests/by-util/test_cksum.rs Show resolved Hide resolved

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from e92cfab to 204d05f Compare November 3, 2025 06:07

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from 204d05f to 661934b Compare November 3, 2025 06:16

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from 661934b to dee3483 Compare November 3, 2025 06:56

naoNao89 closed this by deleting the head repository Nov 6, 2025

naoNao89 reopened this Nov 7, 2025

naoNao89 changed the title ~~cksum: Add SHA3/SHAKE support and --debug flag~~ cksum: Add SHA3/SHAKE support Dec 7, 2025

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from 2e90544 to c7b5914 Compare December 27, 2025 20:11

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from c7b5914 to 3495d31 Compare December 29, 2025 08:35

naoNao89 force-pushed the fix-cksum-sha3-debug-8933 branch from 3495d31 to 3583fd9 Compare December 29, 2025 14:28

cakebaker closed this Jan 2, 2026

Uh oh!

Conversation

naoNao89 commented Oct 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 18, 2025

Uh oh!

sylvestre commented Oct 18, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

sylvestre commented Oct 21, 2025

Uh oh!

naoNao89 commented Oct 21, 2025

Uh oh!

github-actions bot commented Oct 21, 2025

Uh oh!

sylvestre left a comment

Choose a reason for hiding this comment

Uh oh!

codspeed-hq bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8948 will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

Uh oh!

cakebaker Oct 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

sylvestre commented Dec 5, 2025

Uh oh!

naoNao89 commented Dec 6, 2025

Uh oh!

github-actions bot commented Dec 6, 2025

Uh oh!

oech3 commented Dec 26, 2025

Uh oh!

naoNao89 commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 27, 2025

Uh oh!

github-actions bot commented Dec 29, 2025

Uh oh!

cakebaker commented Jan 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

naoNao89 commented Oct 18, 2025 •

edited

Loading

codspeed-hq bot commented Oct 30, 2025 •

edited

Loading