Skip to content

Conversation

@naoNao89
Copy link
Contributor

Replace generic .unwrap() calls with .expect() containing descriptive messages that document critical assumptions about signal availability and argument validation.

  • SIGTERM: .expect("TERM signal should always be valid")
  • SIGKILL: .expect("KILL signal should always be valid")
  • SIGCONT: .expect("CONT signal should always be valid")

These are POSIX.1 standard signals guaranteed on all Unix systems. See GNU manual - Signal specifications.

@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@naoNao89 naoNao89 force-pushed the timeout-error-handling branch 2 times, most recently from 24ce1f3 to 0bce409 Compare January 5, 2026 00:39
@naoNao89 naoNao89 force-pushed the timeout-error-handling branch from 0bce409 to 22b63ee Compare January 5, 2026 00:55
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 5, 2026

CodSpeed Performance Report

Merging #9435 will improve performance by 3.53%

Comparing naoNao89:timeout-error-handling (22b63ee) with main (666c6df)

Summary

⚡ 1 improvement
✅ 138 untouched
⏩ 37 skipped1

Benchmarks breakdown

Benchmark BASE HEAD Efficiency
tsort_input_parsing_heavy[5000] 73 ms 70.5 ms +3.53%

Footnotes

  1. 37 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant