Changing integration tests to use sudo in instances where its required #9462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
|
@sylvestre It appears that most of the tests that require root, even when they have the ability to use root on the CI are just not functioning either locally or on the CI. I was thinking of incrementally enabling them to run on the CI. Is this something that you would be open to allowing or moving towards? Was thinking of starting with changing the is root to another helper works on CI and gradually move the tests over one by one so that they will begin to run on the CI but it would be too much for a single PR |
|
GNU testsuite comparison: |
This was referenced Nov 26, 2025
ChrisDryden
force-pushed
the
sudo_coverage
branch
from
f0b6851 to
3cab72c
Compare
ChrisDryden
changed the title
…igrating all commands
ChrisDryden
force-pushed
the
sudo_coverage
branch
from
3cab72c to
64fb8ee
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been noticing that when I run the test suite locally I have a bunch of failing tests and it appears that a common cause of the failures is that the tests broke long ago but we skip a bunch of tests in the CI if the root permission is needed to test a feature.
To be able to track regressions and determine whether we have code coverage across the library in the long term we need to have a mechanism to be able to run these commands on the build fleet. I first tried running the integration tests as sudo but found that it ended up changing the behaviour of the tests. The next thing I tried was to change the util that runs the sudo command in the tests to be able to run on the CI fleet.