env: should not panic when receiving invalid input #9493
Conversation
|
GNU testsuite comparison: |
| stdout, | ||
| "{}={}{line_ending}", | ||
| n.to_string_lossy(), | ||
| v.to_string_lossy() |
There was a problem hiding this comment.
I think that's not correct because GNU env doesn't output a lossy string:
$ FOO=$'\xFF\xFE' env | hexdump -C
46 4f 4f 3d ff fe // I omitted everything else
I don't know about the key, I wasn't able to create an env var whose key contains a non-utf8 char.
There was a problem hiding this comment.
Environmental variables aren't necessarily the utf8-encoded strings we want them to be. They're null terminated binary strings (hopefully containing a = but I'm not even sure that is enforced). This is unfortunately the kind of place where that distinction matters.
|
@cakebaker, context for this PR can be found here: https://bugs.launchpad.net/ubuntu/+source/rust-coreutils/+bug/2132941 |
|
I realized today that this issue comes from a failing Perl test. |
4 participants
No description provided.