Add functionality to show when tests were previously skipped and now failing accurately #9521
+80
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…failing accurately
ChrisDryden
force-pushed
the
skip_to_fail
branch
from
4fff27e to
a917791
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a change that will re-enable the stty tests in the CI that I've been working on #9336 and it currently has the issue that when re-enabling skipped tests that become failures, its treated as a failure for the workflow and the comment that's added to the pipeline indicates that the test was originally passing before.
This change splits the tests that were skipped from passing before and gives a correct comment now.