Skip to content

dd: Handle slow transfer rates in progress display #9529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

dd: Handle slow transfer rates in progress display #9529

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52e2da9
dd: Handle slow transfer rates in progress display
martinkunkel2 Nov 30, 2025
bb58a69
dd: Fix review findings
martinkunkel2 Dec 1, 2025
6edcd15
Merge branch 'main' into dd-print-slow-transfer-rate
martinkunkel2 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/uu/dd/src/progress.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ impl ProgUpdate {
// Compute the throughput (bytes per second) as a string.
let duration = self.duration.as_secs_f64();
let safe_millis = std::cmp::max(1, self.duration.as_millis());
let rate = 1000 * (btotal / safe_millis);
let rate = (1000u128 * btotal) / safe_millis;
let transfer_rate = to_magnitude_and_suffix(rate, SuffixType::Si);

// If we are rewriting the progress line, do write a carriage
Expand Down Expand Up @@ -644,15 +644,15 @@ mod tests {
prog_update.write_prog_line(&mut cursor, rewrite).unwrap();
assert_eq!(
std::str::from_utf8(cursor.get_ref()).unwrap(),
"1 byte copied, 1 s, 0.0 B/s\n"
"1 byte copied, 1 s, 1.0 B/s\n"
);

let prog_update = prog_update_write(999);
let mut cursor = Cursor::new(vec![]);
prog_update.write_prog_line(&mut cursor, rewrite).unwrap();
assert_eq!(
std::str::from_utf8(cursor.get_ref()).unwrap(),
"999 bytes copied, 1 s, 0.0 B/s\n"
"999 bytes copied, 1 s, 999 B/s\n"
);

let prog_update = prog_update_write(1000);
Expand Down
Loading