Skip to content

Conversation

@ognevny
Copy link

@ognevny ognevny commented Dec 1, 2025

requires libc patch, mio v1.1.0 and nix patch. behavior is mostly matched with Linux. UNIX_PROGS are currently not supported due to missing ctor/dtor support of cygwin (and possibly a bit more issues)

fixes #5417

@sylvestre
Copy link
Contributor

please format the code! thanks

@ognevny
Copy link
Author

ognevny commented Dec 1, 2025

please format the code! thanks

I'm in hurry a bit. done

@sylvestre
Copy link
Contributor

please format the code! thanks

I'm in hurry a bit. done

well, i am not :) so, please take your time :)

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@ognevny ognevny marked this pull request as draft December 1, 2025 08:24
@ognevny
Copy link
Author

ognevny commented Dec 1, 2025

I started to test it, and it seems that signals handling is broken... needs investigation :(
edit:

==>  MINGW_ARCH: clang64
  -> Building clang64...
/etc/post-install/05-home-dir.post: строка 4: exec: id: не найден
==> Сборка пакета mingw-w64-dust 1.2.3-1 (2025 M12 1, Mon 11:23:41)
==> Проверка зависимостей для запуска...
==> Проверка зависимостей для сборки...
/usr/bin/makepkg: строка 1297: chmod: команда не найдена

==> ОШИБКА: An unknown error has occurred. Exiting...
==> Очистка...
/usr/bin/makepkg-mingw: строка 112: 16910 User defined signal 1   MSYSTEM="${_mingw^^}" CHERE_INVOKING=1 bash -leo pipefail -c "/usr/bin/makepkg --config /etc/makepkg_mingw.conf \"\$@\"" bash "$@"

@oech3
Copy link
Contributor

oech3 commented Dec 1, 2025 via email

@ognevny
Copy link
Author

ognevny commented Dec 1, 2025

Please use LANG=C makepkg .

messages in Russian are printed by makepkg, so it doesn't matter much

edit: but yeah, chmod is missing

@ognevny ognevny force-pushed the cygwin-support branch 2 times, most recently from 6113cda to 6747b40 Compare December 1, 2025 09:19
@ognevny
Copy link
Author

ognevny commented Dec 1, 2025

ctor doesn't support Cygwin so I have to leave it without UNIX_PROGS for now

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

@ognevny ognevny marked this pull request as ready for review December 1, 2025 09:54
@ognevny
Copy link
Author

ognevny commented Dec 1, 2025

I started to test it, and it seems that signals handling is broken... needs investigation :(

for reference they're defined here: https://cygwin.com/cgit/newlib-cygwin/tree/winsup/cygwin/include/cygwin/signal.h#n425

@oech3

This comment was marked as resolved.

@oech3
Copy link
Contributor

oech3 commented Dec 1, 2025

requires mio v1.1.0

Is different PR to bump mio possible?

@ognevny
Copy link
Author

ognevny commented Dec 1, 2025

requires mio v1.1.0

Is different PR to bump mio possible?

no, these deps must update mio first

❯ cargo tree --invert -p mio
mio v1.0.4
├── *crossterm v0.29.0*
│   └── uu_more v0.4.0 (/home/ogn/forks/coreutils/src/uu/more)
│       └── coreutils v0.4.0 (/home/ogn/forks/coreutils)
├── *notify v8.2.0*
│   └── uu_tail v0.4.0 (/home/ogn/forks/coreutils/src/uu/tail)
│       └── coreutils v0.4.0 (/home/ogn/forks/coreutils)
└── *signal-hook-mio v0.2.4*
    └── crossterm v0.29.0

@ognevny ognevny force-pushed the cygwin-support branch 2 times, most recently from 0406678 to 31fbcbc Compare December 1, 2025 12:31
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #9535 will not alter performance

Comparing ognevny:cygwin-support (fa71913) with main (003f21a)

Summary

✅ 126 untouched
⏩ 6 skipped1

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

requires [libc
patch](rust-lang/libc@a3bb40e), mio
v1.1.0 and [nix patch](nix-rust/nix#\2708). behavior is mostly matched with Linux
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

1 similar comment
@github-actions
Copy link

github-actions bot commented Dec 1, 2025

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cat: os error 3 on MSYS2 package

3 participants