fix(Basenc):fix GNU coreutils test bounded-memory.sh #9536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce streaming input processing for encode/decode operations, using BufReader for buffered reads. This avoids loading entire input into memory, preventing OOM for large files. Base58 retains buffered behavior due to its requirement to process input as one big integer, preserving historical compatibility. Remove obsolete ReadSeek trait and buffer-reading logic.
…fast encode/decode Improve error handling for I/O read operations by wrapping errors with USimpleError for better user feedback. Refactor the invalid input logic in fast_decode to ensure correct chunk flushing before returning errors, supporting both partial and non-partial decode modes.
- Updated the spell-checker ignore comment in base_common.rs to include 'behaviour' - Fixes false positive spell-checker warning, likely due to British English spelling being used in code or comments
CodSpeed Performance ReportMerging #9536 will degrade performances by 3.48%Comparing Summary
Benchmarks breakdown
Footnotes
|
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the test for bounded-memory.sh in GNU coreutils to pass.
related
#9127