unit test coverage: fix missing coverage#9606
Conversation
|
GNU testsuite comparison: |
1 similar comment
|
GNU testsuite comparison: |
fbe128f to
3706e9e
Compare
|
GNU testsuite comparison: |
|
compared results: on main: 41164 of 46764 lines covered and example lines.rs: https://app.codecov.io/gh/uutils/coreutils/blob/martinkunkel2%2Fcoreutils%3Acoverage-for-unit-tests/src%2Fuucore%2Fsrc%2Flib%2Ffeatures%2Flines.rs |
|
Is it accurate to have the unit test lines counted as lines to track? https://app.codecov.io/gh/uutils/coreutils/blob/main/src%2Fuucore%2Fsrc%2Flib%2Ffeatures%2Flines.rs |
|
valid remark. I'll investigate |
binary-path option of grcov needs to be set to full target/debug folder to include unit test binaries.
eda9b3b to
500c43e
Compare
|
GNU testsuite comparison: |
500c43e to
9c8bf1b
Compare
|
GNU testsuite comparison: |
9c8bf1b to
7067251
Compare
|
@ChrisDryden : I could apply a filter that removes the test code from coverage, see 7067251 Latest test run: https://app.codecov.io/gh/uutils/coreutils/blob/martinkunkel2%2Fcoreutils%3Acoverage-for-unit-tests/src%2Fuucore%2Fsrc%2Flib%2Ffeatures%2Flines.rs |
|
@sylvestre : this is ready for review. |
|
GNU testsuite comparison: |
RenjiSann
left a comment
There was a problem hiding this comment.
Looks good to me !
Thank you !
binary-path option of grcov needs to be set to full target/debug folder to include unit test binaries.
This fixes #9597