fix(shred): stop immediately on write errors #9649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
naoNao89
force-pushed
the
fix/issue-7947-shred-error-handling
branch
from
0b0877a to
b805fbd
Compare
Replace show_if_err!() with ? operator in wipe_file() to properly propagate errors and stop pass loop on first write failure. This matches GNU shred behavior where any write error (disk quota, I/O error, etc.) stops execution immediately instead of continuing with remaining passes. Changes: - src/uu/shred/src/shred.rs: Use ? operator for error propagation - tests/by-util/test_shred.rs: Enable previously ignored test
naoNao89
force-pushed
the
fix/issue-7947-shred-error-handling
branch
from
b805fbd to
9f96b95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7947
Replace
show_if_err!()with?operator in wipe_file() to properly propagate errors and stop immediately on write failures, matching GNU shred. Previously continued all passes despite errors. Enables previously ignored testtest_random_source_dir.