-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test: add matches_gnu() method for comparing output against GNU coreutils #9660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
GNU testsuite comparison: |
|
Lol I think this actually caught an issue in the first one I tried. The echo on these platforms is actually using the bash built in echo |
07ed3cd to
fa467ae
Compare
CodSpeed Performance ReportMerging #9660 will not alter performanceComparing Summary
Footnotes
|
|
GNU testsuite comparison: |
|
Looks like it actually was a bug on my end, should be good for starting to review |
|
i don't think we want to do that. |
|
I've come across a bunch of our own integration tests that test for things that don't match the GNU integration tests, its tricky to add to the ones that also change the state of the environment so it can't be added to all of them directly. Maybe I could use this and add it to all of the tests in a utility to show how some tests diverge? |
|
have a look to the fuzzers. example: |
This is something I was hoping we could add to every integration test we have. We have all of these integration tests for regression, but we don't test GNU using those integration tests to see if those integration tests are even correct. Once this is in I was hoping to add this to as many tests as possible to surface when the integration tests are not matching the behaviour of the GNU implementation