feat(timeout): add benchmarking support with divan #9733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dev-dependencies for divan and uucore benchmarking features, and configure a new bench target for timeout command performance testing. This enables automated benchmarking to track and optimize execution times.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
Author
This is a temporary error. |
Contributor
|
it seems that divan isn't identifying these new benchmarks |
Remove the unnecessary `mod unix` block and use `#[cfg(unix)]` attributes on imports, functions, and benchmarks. Adjust `main()` to conditionally call `divan::main()` for Unix platforms. This refactoring improves code readability and reduces module nesting without changing functionality.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Include benchmarking for the uu_timeout utility to ensure performance tracking alongside other tools in the suite.
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
sylvestre
reviewed
Dec 30, 2025
| @@ -0,0 +1,108 @@ | |||
| // This file is part of the uutils coreutils package. | |||
Contributor
There was a problem hiding this comment.
this isn't the right way to call the benchmark.
we should call the rust function (see others)
… logic Replace complex child mode spawning with direct command arguments for cleaner and more maintainable benchmarks, reducing overhead and improving readability. Use "true" for quick-exit and "sleep" for enforced timeout tests.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dev-dependencies for divan and uucore benchmarking features, and configure a new bench target for timeout command performance testing. This enables automated benchmarking to track and optimize execution times.
related
#9100 (comment)