uucore: fix clippy::pedantic warnings in build.rs and generated locale code#9837
Merged
sylvestre merged 2 commits intouutils:mainfrom Dec 25, 2025
Merged
uucore: fix clippy::pedantic warnings in build.rs and generated locale code#9837sylvestre merged 2 commits intouutils:mainfrom
sylvestre merged 2 commits intouutils:mainfrom
Conversation
|
GNU testsuite comparison: |
|
GNU testsuite comparison: |
Contributor
|
Could you please update github action to run it in the ci? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This PR addresses several
clippy::pedanticwarnings related to the locale embedding logic inuucore.Changes:
# Errorssection to theembed_locale_filedocumentation inbuild.rs.build.rsto dynamically handle raw string literals. It now detects if the translation content contains double quotes and uses the appropriate hash delimiter (r"..."vsr#"..."#).clippy::needless_raw_string_hashesin the generated output.Testing: Verified by running
cargo clippy -p uu_whoami -- -W clippy::pedanticand confirming the warnings related tobuild.rsand the generated locale code are gone.