sort: fixing locale benchmarks since locale is cached in OnceCell #9914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDryden
force-pushed
the
fix/sort-locale-benchmarks
branch
from
1fa959e to
4e80f2b
Compare
ChrisDryden
changed the title
sgmarz
pushed a commit
to sgmarz/coreutils
that referenced
this pull request
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was looking through @sylvestre's pr related to sorting and locale and the regressions did not make intuitive sense to me. The issue is that the OnceCell locks the locale after the first run so that since the first run is using a non C locale it slows down the C locale run.
By splitting the benches to be locale specific it will actually benchmark what we are looking to benchmark