Skip to content

Conversation

@mattsu2020
Copy link
Contributor

To ensure compatibility with GNU coreutils, we will make modifications so that the tests pass.

date-ethiopia.sh

@mattsu2020 mattsu2020 marked this pull request as draft December 30, 2025 05:29
@mattsu2020 mattsu2020 changed the title date:gnu compatibility (date ethiopia.sh) date:gnu coreutils compatibility (date ethiopia.sh) Dec 30, 2025
@sylvestre
Copy link
Contributor

why do we need a new complex file for that? thanks

…nce `strftime` formatting with new specifiers and Ethiopian calendar support.
@sylvestre
Copy link
Contributor

Sorry, it was a general statement to say that i am not a fan of the added complexity of this pr
it feels to complex (not mentioning the long list of if / else)

@mattsu2020
Copy link
Contributor Author

Sorry, it was a general statement to say that i am not a fan of the added complexity of this pr it feels to complex (not mentioning the long list of if / else)

We will split the PR.

@mattsu2020 mattsu2020 closed this Dec 30, 2025
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/date/resolution. tests/date/resolution is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/tty/tty-eof. tests/tty/tty-eof is passing on 'main'. Maybe you have to rebase?
Congrats! The gnu test tests/date/date-ethiopia is no longer failing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants