Skip to content

Conversation

@cerdelen
Copy link
Contributor

Fix the Error message for tac when trying to give a directory as input.

Issue: #9938

@github-actions
Copy link

GNU testsuite comparison:

Congrats! The gnu test tests/tty/tty-eof is no longer failing!

#[error("{}", translate!("tac-error-invalid-argument", "argument" => .0.maybe_quote()))]
InvalidArgument(OsString),
/// The argument to tac is a directory.
#[error("{}", translate!("tac-error-invalid-directory-argument", "argument" => .0.maybe_quote()))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think tac-error-invalid-argument should be removed, no ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh from the locale?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, from the fluent files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the oversight

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, don't be sorry

@cakebaker cakebaker linked an issue Dec 31, 2025 that may be closed by this pull request
@sylvestre sylvestre merged commit e3be131 into uutils:main Dec 31, 2025
128 of 130 checks passed
sgmarz pushed a commit to sgmarz/coreutils that referenced this pull request Jan 7, 2026
* tac: fix error message

* tac: Remove obsolete error messages from locales
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tac: tac directory have a bad error message

2 participants