Skip to content

Conversation

@bezmuth
Copy link

@bezmuth bezmuth commented Aug 5, 2025

This fixes: uutils/coreutils#7520
This is my first pr to the uutils repos so there is a good chance I've made a few mistakes, I'm not entirely sure if I've chosen the right name for functions/variables either. I can write some tests for the TZ= functionality but I want to make sure I haven't missed anything yet.

@cakebaker
Copy link
Collaborator

cakebaker commented Aug 5, 2025

Can you please run cargo fmt and cargo clippy? Thanks! And yes, please write some tests :)

@cakebaker
Copy link
Collaborator

@yuankunzhang I have seen you started with the migration from chrono to jiff whereas this PR adds more code that uses chrono :| Is it ok if I merge this PR or would it cause too much hassle for what you are working on?

@yuankunzhang
Copy link
Contributor

It is better for this PR to wait until the jiff migration is completed.

@yuankunzhang
Copy link
Contributor

Hi @bezmuth , now that we have completed the chrono to jiff migration, could you please refactor your code based on the latest main branch? Thanks.

@bezmuth
Copy link
Author

bezmuth commented Aug 27, 2025

Yep, I'll get on it. Jiff seems a lot more robust for timezones

@cakebaker
Copy link
Collaborator

Closing this PR as the functionality has been added in #232

@bezmuth thanks anyway for your PR!

@cakebaker cakebaker closed this Sep 25, 2025
@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (25f9e48) to head (50bf621).
⚠️ Report is 50 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #200   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date: invalid date 'TZ="GMT" 2025-02-01'

3 participants