pidwait: Use common process_matcher (+ move a pidwait feature there)#323
Merged
Krysztal112233 merged 3 commits intouutils:mainfrom Feb 18, 2025
Merged
pidwait: Use common process_matcher (+ move a pidwait feature there)#323Krysztal112233 merged 3 commits intouutils:mainfrom
Krysztal112233 merged 3 commits intouutils:mainfrom
Conversation
dezgeg
force-pushed
the
pgrep_pkill_unification3
branch
2 times, most recently
from
9cb9c21 to
5a11134
Compare
cakebaker
reviewed
Feb 17, 2025
pidwait already has a check for this, copy it to the common process_matcher implementation. Some tests need adjustment to not use such long fake names.
Its matching functionality should be a superset of what pidwait can currently do.
dezgeg
force-pushed
the
pgrep_pkill_unification3
branch
from
5a11134 to
b633a46
Compare
Krysztal112233
approved these changes
Feb 18, 2025
Collaborator
Krysztal112233
left a comment
Krysztal112233
left a comment
There was a problem hiding this comment.
It's very exciting, thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy remaining process-matching feature of pidwait to process_matcher so pgrep and pkill can utilize it, then move pidwait to use the common process_matcher as well.