-
Notifications
You must be signed in to change notification settings - Fork 34
watch: handle WATCH_INTERVAL #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
07ccb18 to
d8d3eaa
Compare
|
Ah, thanks for your contributing and please fix CI failure, you have to format your code using |
d8d3eaa to
33a55e6
Compare
|
Thanks for the prompt feedback! The code should now be properly formatted. |
|
Ah, CI failed. failures:
---- test_watch::test_interval_environment_variable stdout ----
run: /Users/runner/work/procps/procps/target/debug/procps watch echo -n hello
thread 'test_watch::test_interval_environment_variable' panicked at tests/by-util/test_watch.rs:86:10:
assertion failed: `(left == right)`: stdout as bytes wasn't equal to expected bytes. Result as strings:
stdout ='Ok("-n hello\n-n hello\n")'
expected='Ok("hellohello")'
Diff < left / right > :
[
< 45,
< 110,
< 32,
104,
101,
108,
108,
111,
< 10,
< 45,
< 110,
< 32,
104,
101,
108,
108,
111,
< 10,
]
failures:
test_watch::test_interval_environment_variable
test result: FAILED. 82 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.63s
error: test failed, to rerun pass `-p procps --test tests`could you please fix it? |
|
Sorry for the delay. I'll get back to this when I have time to debug this apparently macos-specific issue (the test passes locally on my linux machine - the linux CI didn't run yet on this branch). |
33a55e6 to
8bee899
Compare
8bee899 to
70d4f9a
Compare
|
Can you please run |
70d4f9a to
5324857
Compare
5324857 to
20d7f29
Compare
|
Thanks for your PR! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Resolves #25.
Handle
WATCH_INTERVAL, as override for the-n, --intervaloption inwatch.