Skip to content

Conversation

@dezgeg
Copy link
Contributor

@dezgeg dezgeg commented Mar 24, 2025

Lots of tests rely on finding kthreadd thus -w flag needs to be added to them.

Lots of tests rely on finding kthreadd thus -w flag needs to be added
to them.
@Krysztal112233
Copy link
Collaborator

Krysztal112233 commented Mar 25, 2025

Hmm, which version of procps-ng are you using?

➜  procps git:(pidof-w) cargo run -q pidof kthreadd
➜  procps git:(pidof-w) pidof kthreadd
2
➜  procps git:(pidof-w) pidof -h
pidof usage: [options] <program-name>

 -c           Return PIDs with the same root directory
 -d <sep>     Use the provided character as output separator
 -h           Display this help text
 -n           Avoid using stat system function on network shares
 -o <pid>     Omit results with a given PID
 -q           Quiet mode. Do not display output
 -s           Only return one PID
 -x           Return PIDs of shells running scripts with a matching name
 -z           List zombie and I/O waiting processes. May cause pidof to hang.

@dezgeg
Copy link
Contributor Author

dezgeg commented Mar 25, 2025

From Arch Linux: pidof from procps-ng 4.0.5-dirty

Your version of pidof doesn't look like it's from procps-ng but sysvinit-utils (assuming Ubuntu)

@Krysztal112233
Copy link
Collaborator

Yes. Great work, thanks for your contributing :)

@Krysztal112233 Krysztal112233 merged commit 8f6c633 into uutils:main Mar 25, 2025
14 checks passed
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (eb0871a) to head (9fb6aa3).
Report is 9 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #365   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants