Skip to content

vmstat: implement most functions #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cakebaker merged 7 commits into from
Apr 21, 2025
Merged

vmstat: implement most functions #388

cakebaker merged 7 commits into from
Apr 21, 2025

Conversation

@Bluemangoo
Copy link
Collaborator

@Bluemangoo Bluemangoo commented Apr 5, 2025 •
edited
Loading

  • delay
  • count
  • --active
  • --forks
  • --slabs
  • --one-header
  • --stats
  • --disk
  • --disk-sum
  • --partition
  • --unit
  • --timestamp
  • --wide
  • --no-first

@Bluemangoo Bluemangoo force-pushed the feature/vmstat-impl branch from 5051f92 to 6aadf25 Compare April 5, 2025 07:09
sylvestre
sylvestre reviewed Apr 5, 2025
View reviewed changes
@Bluemangoo Bluemangoo force-pushed the feature/vmstat-impl branch from 6aadf25 to 56c5b04 Compare April 5, 2025 07:26
@cakebaker
Copy link
Contributor

cakebaker commented Apr 5, 2025

Just a reminder, you can also do smaller PRs, not everything has to be in a single PR ;-)

@Bluemangoo Bluemangoo force-pushed the feature/vmstat-impl branch from f072e3d to ff351c2 Compare April 14, 2025 14:44
@Bluemangoo Bluemangoo marked this pull request as ready for review April 14, 2025 14:45
@Bluemangoo Bluemangoo force-pushed the feature/vmstat-impl branch 2 times, most recently from c65bb00 to b1eb5f9 Compare April 14, 2025 14:55
@Bluemangoo Bluemangoo force-pushed the feature/vmstat-impl branch from b1eb5f9 to 57cf05d Compare April 14, 2025 14:57
@Bluemangoo
Copy link
Collaborator Author

Bluemangoo commented Apr 14, 2025

enough for this pr.

@sylvestre sylvestre requested a review from Copilot April 14, 2025 15:14
Copilot AI reviewed Apr 14, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

sylvestre
sylvestre reviewed Apr 14, 2025
View reviewed changes
cakebaker
cakebaker reviewed Apr 16, 2025
View reviewed changes
cakebaker
cakebaker reviewed Apr 16, 2025
View reviewed changes
cakebaker
cakebaker reviewed Apr 16, 2025
View reviewed changes
@Bluemangoo Bluemangoo force-pushed the feature/vmstat-impl branch from d0177a7 to 91f48aa Compare April 16, 2025 15:39
@Bluemangoo Bluemangoo force-pushed the feature/vmstat-impl branch from 91f48aa to 389a9f6 Compare April 16, 2025 15:41
@Bluemangoo
Copy link
Collaborator Author

Bluemangoo commented Apr 16, 2025

all fixed.

cakebaker
cakebaker reviewed Apr 19, 2025
View reviewed changes
cakebaker
cakebaker reviewed Apr 19, 2025
View reviewed changes
cakebaker
cakebaker reviewed Apr 19, 2025
View reviewed changes
@Bluemangoo
Copy link
Collaborator Author

Bluemangoo commented Apr 21, 2025

all fixed. @cakebaker

@Bluemangoo Bluemangoo requested a review from cakebaker April 21, 2025 10:40
@cakebaker cakebaker merged commit 95c749c into uutils:main Apr 21, 2025
@cakebaker
Copy link
Contributor

cakebaker commented Apr 21, 2025

Good work, thanks!

@Bluemangoo Bluemangoo deleted the feature/vmstat-impl branch July 13, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sylvestre sylvestre Awaiting requested review from sylvestre

@cakebaker cakebaker Awaiting requested review from cakebaker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bluemangoo @cakebaker @sylvestre