Add hugetop command #392
Closed
Add hugetop command #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
I wanted to reuse some functionality from |
Closed
Krysztal112233
requested changes
Jun 28, 2025
Collaborator
Krysztal112233
left a comment
Krysztal112233
left a comment
There was a problem hiding this comment.
I apologize for the late review of this PR. Since Debian's procps-ng does not currently include hugetop, I will continue the review later. I'm very sorry!
Collaborator
|
And since there were some conflicts due to the commits that were previously merged, could you please help fix them? |
eduardorittner
force-pushed
the
main
branch
2 times, most recently
from
575272b to
7c90f10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hugetop command displays system-wide hugepage informantion as well as per-process hugepage information.
It has the flags
--human(for human-readable size output),--numa(to display info per numa core),--delay <N>(for display refresh) and--once(to only display once then exit). For now none of these flags are supported, and we currently only print once and then exit.The info shown is also very minimal, but it's the same one which is displayed by the original hugetop. Since we get the info from
/proc/meminfoand/sys/kernel/mm/hugepages/hugepages-<size>/...this is not portable at all and only works on linux.