pmap: implemented show-path option #418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
reviewed
May 16, 2025
tests/by-util/test_pmap.rs
Outdated
Comment on lines
278
to
282
| let re = if show_path { | ||
| Regex::new(r"(?m)^[0-9a-f]{16} +[1-9][0-9]*K (-|r)(-|w)(-|x)(-|s)- ( \[ (anon|stack) \]|/[/a-zA-Z0-9._-]+)$").unwrap() | ||
| } else { | ||
| Regex::new(r"(?m)^[0-9a-f]{16} +[1-9][0-9]*K (-|r)(-|w)(-|x)(-|s)- ( \[ (anon|stack) \]|[a-zA-Z0-9._-]+)$").unwrap() | ||
| }; |
Contributor
There was a problem hiding this comment.
Maybe it would make sense to split the regexes to make it easier to see the (small) differences? Something like:
let base_pattern = "<pattern for the identical part>";
let mapping_pattern = if show_path {
"<pattern path expected>"
} else {
"<pattern no path expected>"
};
let re = Regex::new(&format("{base_pattern}{mapping_pattern}")).unwrap();
Contributor
Author
There was a problem hiding this comment.
Thanks for your suggestion!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Good work, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the show-path option.