pmap: implemented quiet option #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
reviewed
May 20, 2025
tests/by-util/test_pmap.rs
Outdated
Comment on lines
312
to
315
| if !quiet { | ||
| let re = Regex::new("^ total +[1-9][0-9]*K$").unwrap(); | ||
| assert!(re.is_match(last_line)); | ||
| } |
Contributor
There was a problem hiding this comment.
You have to handle both the if and the else case. Otherwise, if quiet is true, you simply skip the assert without ensuring there is no "total" line. And thus the test passes even without the changes you made to pmap.rs and pmap_config.rs ;-)
Contributor
Author
There was a problem hiding this comment.
That’s true, thank you for pointing out!
cakebaker
reviewed
May 21, 2025
Co-authored-by: Daniel Hofstetter <[email protected]>
Contributor
|
Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #423 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the quiet option.