Skip to content

Conversation

@Taxrosdev
Copy link
Contributor

If 0.0, it would (and should've) defaulted to 0.1, but if only 0 then it defaulted to 0 (Incorrect behaviour). This PR fixes that.

Added some tests as well :)

@Taxrosdev
Copy link
Contributor Author

Interesting that unit tests would break (even in the main branch) without the env feature on clap, added to fix unit tests failing.

@cakebaker
Copy link
Contributor

Interesting that unit tests would break (even in the main branch) without the env feature on clap, added to fix unit tests failing.

Good catch! Surprised it's not caught by the compiler when running cargo test --all.

@cakebaker cakebaker merged commit 394ee97 into uutils:main Jun 11, 2025
13 checks passed
@cakebaker
Copy link
Contributor

Thanks for your PR!

@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (bf69bef) to head (403830d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff     @@
##   main   #435   +/-   ##
===========================
===========================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants