Skip to content

fix a bug with the deletion pattern#256

Open
sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre:del
Open

fix a bug with the deletion pattern#256
sylvestre wants to merge 1 commit intouutils:mainfrom
sylvestre:del

Conversation

@sylvestre
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 11, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.10%. Comparing base (5e9b821) to head (8613f3e).

Files with missing lines Patch % Lines
src/sed/processor.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #256      +/-   ##
==========================================
- Coverage   82.16%   82.10%   -0.07%     
==========================================
  Files          13       13              
  Lines        5444     5448       +4     
  Branches      304      304              
==========================================
  Hits         4473     4473              
- Misses        969      973       +4     
  Partials        2        2              
Flag Coverage Δ
macos_latest 82.54% <0.00%> (-0.07%) ⬇️
ubuntu_latest 82.66% <0.00%> (-0.07%) ⬇️
windows_latest 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Jan 11, 2026

Merging this PR will degrade performance by 2.46%

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 9 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
number_fix 505.4 ms 518.1 ms -2.46%
access_log_all_del 539.3 ms 508.7 ms +6.01%

Comparing sylvestre:del (8613f3e) with main (5e9b821)

Open in CodSpeed

@uutils uutils deleted a comment from github-actions bot Jan 12, 2026
@uutils uutils deleted a comment from github-actions bot Jan 12, 2026
@sylvestre sylvestre force-pushed the del branch 2 times, most recently from c964deb to d4afc8f Compare January 12, 2026 10:09
@uutils uutils deleted a comment from github-actions bot Jan 12, 2026
@github-actions
Copy link
Copy Markdown

GNU sed testsuite comparison:

Test results comparison:
  Current:   TOTAL: 64 / PASSED: 13 / FAILED: 51 / SKIPPED: 0
  Reference: TOTAL: 64 / PASSED: 8 / FAILED: 56 / SKIPPED: 0

Changes from main branch:
  TOTAL: +0
  PASSED: +5
  FAILED: -5

New test failures (3):
  - execute-tests_n_3
  - madding_triplet
  - uniq_triplet

Test improvements (8):
  + append
  + delete_line
  + delete_range
  + insert
  + line_address
  + print_line
  + range_address
  + word_class

@cakebaker
Copy link
Copy Markdown
Contributor

Sorry, the PR needs a rebase :|

Add pattern_deleted flag to ProcessingContext to prevent automatic
pattern printing after 'd', 'D', and 'c' commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants