Improve GNU sed testsuite compatibility#345
Open
kevinburkesegment wants to merge 1 commit intouutils:mainfrom
Open
Improve GNU sed testsuite compatibility#345kevinburkesegment wants to merge 1 commit intouutils:mainfrom
kevinburkesegment wants to merge 1 commit intouutils:mainfrom
Conversation
cf46e9e to
60beef3
Compare
|
GNU sed testsuite comparison: |
- Fix `l` command default width from 60 to 70 (matching GNU sed) - Wire `-l` flag and COLS env var to `l` command width - Reject `l<N>` (GNU extension) in --posix mode - Accept `}` and `#` as valid command terminators (fixes command-endings) - Accept `}` and `#` as valid substitute flag terminators - Eat spaces before command endings (e.g. `y/1/a/ ;d`) - Scope `#n` silent mode to first script source only (fixes comment-n) - Drop backslash for unknown escape sequences in s/// replacement (GNU behavior) - Match GNU sed error message format: `-e expression #N, char C:` for string scripts, `file:line:` for file scripts - Add `get_source_index()` to ScriptLineProvider - Add test-results.txt to .gitignore GNU testsuite results: 7 → 9 passing (command-endings, comment-n now pass). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
60beef3 to
e391df1
Compare
|
GNU sed testsuite comparison: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 82.16% 81.92% -0.25%
==========================================
Files 13 13
Lines 5444 5454 +10
Branches 304 312 +8
==========================================
- Hits 4473 4468 -5
- Misses 969 984 +15
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Sorry but only one commit implementating all the changes isn't the best practice. In a perfect world, one pr changes or at least one commit per fix in this pr |
Contributor
|
For example, it makes it hard to know what is cover by an existing test or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lcommand default width from 60 to 70 (matching GNU sed)-lflag and COLS env var tolcommand widthl<N>(GNU extension) in --posix mode}and#as valid command terminators (fixes command-endings)}and#as valid substitute flag terminatorsy/1/a/ ;d)#nsilent mode to first script source only (fixes comment-n)-e expression #N, char C:for string scripts,file:line:for file scriptsget_source_index()to ScriptLineProviderGNU testsuite results: 7 → 9 passing (command-endings, comment-n now pass).