Conversation
kgryte
reviewed
Feb 27, 2025
jheer
added a commit
that referenced
this pull request
Feb 28, 2025
* feat: Add 32- and 64-bit decimal support. * fix: Fix docs link typo. * feat: Support bigint inputs to decimal32 builder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigUint64Array. 32-bit decimals directly use a backing (signed)Int32Arrayinstead.Note: The
useDecimalBigIntflag causes 32-bit decimals to be returned asnumber-valued integers instead of floating point values with fractional digits. While minimizing changes, this introduces a misnomer, as the results (in the 32-bit case) are notBigIntvalues. We could consider changing the option name (e.g., touseDecimalInt). However, this could be a breaking change so I'm going to consider it for a subsequent PR.Close #32.