Skip to content

fix: don't access SharedArrayBuffer in not isolated environments #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
domoritz wants to merge 1 commit into from
Closed

fix: don't access SharedArrayBuffer in not isolated environments #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/decode/decode-ipc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
* @returns {import('../types.js').ArrowData}
*/
export function decodeIPC(data) {
const source = data instanceof ArrayBuffer || data instanceof SharedArrayBuffer
const source = data instanceof ArrayBuffer || (crossOriginIsolated && data instanceof SharedArrayBuffer)

Check failure on line 28 in src/decode/decode-ipc.js

View workflow job for this annotation

GitHub Actions / Node 22 

'crossOriginIsolated' is not defined
? new Uint8Array(data)
: data;
return source instanceof Uint8Array && isArrowFileFormat(source)
Expand Down
Loading