Fix null field metadata encoding #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables with null columns crashed PyArrow/Polars with "ran out of field metadata", both for stream/file. The bug, eg: a Schema defined 3 columns, but the record batch only wrote metadata for 2 columns because it skipped null columns. PyArrow expected the counts to match. Fixed by writing metadata for all columns, including null ones (they just don't get any actual data buffers). Also added a test + test data files (generated by pyarrow) and encode/decode tests using those.
Contributor
Author
|
@jheer can you have a look? Thanks! |
Member
|
Looks great. Thanks @roelentless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables with null columns crashed PyArrow/Polars with "ran out of field metadata", both for stream/file.
The bug, eg: a Schema defined 3 columns, but the record batch only wrote metadata for 2 columns because it skipped null columns. PyArrow expected the counts to match.
Fixed by writing metadata for all columns, including null ones (they just don't get any actual data buffers).
Also added a test + test data files (generated by pyarrow) and encode/decode tests using those.
Also: awesome library to get going, thanks for kicking off a better JS lib for arrow.