tab bar: Take scroll position into account when making item visible#513
Merged
uwerat merged 1 commit intouwerat:masterfrom May 4, 2025
Merged
Conversation
If the tab bar is scrolled, the position we get from calling mapFromItem() is less than the real position with a scrolling of 0, because mapFromItem() does not know about our scroll position. This is usually not noticed when creating a tab bar, because the scroll position is (0,0). When calling this method on a scrolled tab bar, the problem becomes visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the tab bar is scrolled, the position we get from calling mapFromItem() is less than the real position with a scrolling of 0, because mapFromItem() does not know about our scroll position.
This is usually not noticed when creating a tab bar, because the scroll position is (0,0). When calling this method on a scrolled tab bar, the problem becomes visible.