Skip to content

Conversation

@tonyalaribe
Copy link
Contributor

THis PR upgrades the project to support datafusion v46.

A question, should we bump the version number? And what should I bump it to?
from version = "40.0.0" ==> "41.0.0" ?

@Max-Meldrum
Copy link
Collaborator

This is great! I think it would best to follow the exact datafusion version. So that it is also 46.0.0

@tonyalaribe
Copy link
Contributor Author

Hi @Max-Meldrum, I updated the version.

But I'm looking at the current CI failures and unsure if that's something I can fix in this PR.

TL;DR is that Expr::Wildcard is now deprecated. So the logic has to be implemented differently.

apache/datafusion#7765

  error: use of deprecated variant `datafusion::prelude::Expr::Wildcard`: A wildcard needs to be resolved to concrete expressions when constructing the logical plan. See https://github.com/apache/datafusion/issues/7765
     --> datafusion-uwheel/src/lib.rs:886:15
      |
  886 |         Expr::Wildcard {
      |               ^^^^^^^^
      |
      = note: `-D deprecated` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(deprecated)]`
  
  error: use of deprecated field `datafusion::prelude::Expr::Wildcard::qualifier`: A wildcard needs to be resolved to concrete expressions when constructing the logical plan. See https://github.com/apache/datafusion/issues/7765
     --> datafusion-uwheel/src/lib.rs:887:13
      |
  887 |             qualifier: None,
      |             ^^^^^^^^^^^^^^^
      ```

@Max-Meldrum
Copy link
Collaborator

Hi @Max-Meldrum, I updated the version.

But I'm looking at the current CI failures and unsure if that's something I can fix in this PR.

TL;DR is that Expr::Wildcard is now deprecated. So the logic has to be implemented differently.

apache/datafusion#7765

  error: use of deprecated variant `datafusion::prelude::Expr::Wildcard`: A wildcard needs to be resolved to concrete expressions when constructing the logical plan. See https://github.com/apache/datafusion/issues/7765
     --> datafusion-uwheel/src/lib.rs:886:15
      |
  886 |         Expr::Wildcard {
      |               ^^^^^^^^
      |
      = note: `-D deprecated` implied by `-D warnings`
      = help: to override `-D warnings` add `#[allow(deprecated)]`
  
  error: use of deprecated field `datafusion::prelude::Expr::Wildcard::qualifier`: A wildcard needs to be resolved to concrete expressions when constructing the logical plan. See https://github.com/apache/datafusion/issues/7765
     --> datafusion-uwheel/src/lib.rs:887:13
      |
  887 |             qualifier: None,
      |             ^^^^^^^^^^^^^^^
      ```

We can merge it and then fix it in another follow-up PR. Great work!

@Max-Meldrum Max-Meldrum merged commit d6649c8 into uwheel:main Apr 1, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants