Open
Conversation
This commit adds libunwind explicitly to the linking command.
Member
Author
Member
Author
|
Leaving a more explicit note here: when we enable frame pointers when libunwind is not found, we also need to enable them in our build of gperftools |
Member
|
I think the right thing to do here is redistribute the correct version of libunwind, perhaps with c++11 modifications. But I've had trouble getting libunwind+gperftools to work with Grappa in recent months, and I'm not going to have more time to debug it. You want to take a look sometime? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

GLOG (google logging) depends on libunwind. Sometimes libunwind symbols were not found by the linker.
Without the fix
Proposed fix (c9bc0dd) adds the linking flag explicitly.