Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR unwrap undefined tensor when interfacing with the rest of the pytorch system.
This is because undefined is handle specially in other places.
For example, in autograd, a undefined value will get ignored, but a checkpointed-undefined value will try to be process by the system, leading to an error (because there is nothing to back propagate against).
This happen when you try to do a second order gradient over convolution2d, because conv2d return undefined for values when it dont need to to save time.
There is also some minor fixes that made us play better with autograd. pytorch has weird and poorly documented semantic regarding requrires_grad and dispatch key that I didnt got right.