Set blas cmake options also with PARENT_SCOPE#10
Merged
Rbiessy merged 1 commit intouxlfoundation:mainfrom Apr 22, 2025
Merged
Conversation
This is required for the update value to be visible in a dependent project including generic blas using FetchContent.
Rbiessy
reviewed
Apr 22, 2025
Rbiessy
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #7 dependent projects can read the options
BLAS_ENABLE_COMPLEXandBLAS_ENABLE_USMboth when using an installed generic blas configuration and when usinginclude()to consume the generic blasCMakeLists.txt(as it happens withFetchContent).However, in the latter case, the update of those values when AdaptiveCpp is detected with simple
set()changes only the local value and leaves the parent-scope value at the defaultON. This breaks oneMath compilation with AdaptiveCpp when including generic blas withFetchContent.Detect when the generic blas
CMakeLists.txtis not the top-level project scope (cf. CMake discourse) and change the values of these options also in thePARENT_SCOPE.