Skip to content

Conversation

@rongzha1
Copy link
Contributor

fix JIRA: MFDNN-14495

In the SDPA training pattern, softmax has two outputs, which causes it to fall back to the ::softmax::compute_ref kernel. This reference kernel uses a naive algorithm and has a different implementation from the JIT kernel, which can lead to small numerical discrepancies.

To resolve this failure, reduce the input shape size.

@rongzha1 rongzha1 requested review from a team as code owners December 26, 2025 12:54
@rongzha1 rongzha1 added the component:graph-api Codeowner: @oneapi-src/onednn-graph label Dec 26, 2025
@github-actions github-actions bot added component:tests Codeowner: @oneapi-src/onednn-arch and removed component:graph-api Codeowner: @oneapi-src/onednn-graph labels Dec 26, 2025
@rongzha1
Copy link
Contributor Author

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

Copy link
Contributor

@dzarukin dzarukin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to update it through the options in a list over changing the case directly?

@rongzha1
Copy link
Contributor Author

rongzha1 commented Jan 4, 2026

Would it be better to update it through the options in a list over changing the case directly?

good idea! will change

@rongzha1 rongzha1 force-pushed the rzhang/fix_sdp_training branch 2 times, most recently from 2d198a2 to 0a62fb3 Compare January 4, 2026 06:17
@rongzha1 rongzha1 changed the title tests: bench: graph: using small shape to pass on win platform tests: benchdnn: inputs: graph: using small shape to pass on win platform Jan 4, 2026
@rongzha1 rongzha1 force-pushed the rzhang/fix_sdp_training branch from 0a62fb3 to e838802 Compare January 4, 2026 06:42
@dzarukin dzarukin force-pushed the rzhang/fix_sdp_training branch from e838802 to 7e1c757 Compare January 4, 2026 21:21
@rongzha1
Copy link
Contributor Author

rongzha1 commented Jan 6, 2026

make test
set test_scope=NIGHTLY
disable benchdnn_all
enable benchdnn_graph

@rongzha1 rongzha1 merged commit e65e91b into main Jan 7, 2026
32 of 33 checks passed
@rongzha1 rongzha1 deleted the rzhang/fix_sdp_training branch January 7, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:tests Codeowner: @oneapi-src/onednn-arch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants