You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GPU convolution/deconvolution is not aligned with documentation and can use f16 accumulator even when acc-mode doesn't allow it: link
It's a FIXME but at this point it's easier to wait until XeLP/XeLPG are officially deprecated
I think we should just fix this (unless it causes functionality regressions). It looks like is was just missed when implementing #1540.
GPU convolution/deconvolution is not aligned with documentation and can use f16 accumulator even when acc-mode doesn't allow it: link
It's a FIXME but at this point it's easier to wait until XeLP/XeLPG are officially deprecated
I think we should just fix this (unless it causes functionality regressions). It looks like is was just missed when implementing #1540.
I agree, it's tracked in MFDNN-13271
I currently lack the bandwidth for it so that's why I came up with this more targeted fix in benchdnn to fix the existing Nightly failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: MFDNN-14670
PR addresses two issues:
acc-modeduring data filling (e.g. see the matmul failure below)f16accumulator even whenacc-modedoesn't allow it: linkMatmul failures on XeLP/XeLPG - note
--attr-acc-mode=any: