Conversation
github-actions
bot
added
platform:gpu-intel
dyoussif
force-pushed
the
dyoussif/merge_main
branch
from
16357f1 to
b6e2770
Compare
| case gpu::intel::compute::gpu_arch_t::xe2: | ||
| case gpu_arch_t::xe3p_35_10: | ||
| case gpu_arch_t::xe3p_35_11: | ||
| case gpu_arch_t::xe3p_35_unknown: |
There was a problem hiding this comment.
Nit: same style for prefixes here and one below?
| bool mayiuse_systolic_ = false; | ||
| bool mayiuse_ngen_kernels_ = false; | ||
| bool mayiuse_system_memory_allocators_ = false; | ||
| bool is_efficient_64bit_ = false; |
There was a problem hiding this comment.
Would be nice to have a comment explaining what is efficient 64 bit...
| mov(mod, temp, src1); | ||
| mul(mod, dst, src0, temp); | ||
| state.ra.safeRelease(tempRange); | ||
| }else |
There was a problem hiding this comment.
Is this file in clang-format exception list?
|
|
||
| state.ra.safeRelease(inputs.ldaq); | ||
| state.ra.safeRelease(inputs.ldbq); | ||
| //state.ra.safeRelease(inputs.ldcq); |
| if (!isBlock2D(astrategy.accessType) && !asIfBlock2D) return 0; | ||
| if (hw == HW::Xe2) return 16; | ||
| if (hw == HW::Xe3) return 16; | ||
| if (hw >= HW::XE3P_35_10) return 4; |
There was a problem hiding this comment.
Minor: can it be unsafe for future platforms and lead to potential issues?
| return status::success; | ||
| } | ||
|
|
||
| void debugdump_processed_source(const std::string &source, |
There was a problem hiding this comment.
This function was moved to compute folder, please drop.
|
|
||
| if(DNNL_WITH_XE3P) | ||
| add_definitions_with_host_compiler(-DXE3P=1) | ||
| endif() |
There was a problem hiding this comment.
It feels like this is not needed.
| VCHECK_SDP_PRIMITIVE(false, status::unimplemented, | ||
| "f32 fused sdpa supported for: causal mask or cases with " | ||
| "head_size <= 64, seq_len >= 16"); | ||
| } |
There was a problem hiding this comment.
This reverts the change that is on main. Please drop changes from this file.
| if(DNNL_WITH_XE3P) | ||
| add_definitions_with_host_compiler(-DDNNL_WITH_XE3P) | ||
| add_definitions_with_host_compiler(-DXE3P) | ||
| endif() |
| EXPECT_EQ(num_inplace_pairs, 0U); | ||
| #else | ||
| EXPECT_EQ(num_inplace_pairs, engine == dnnl_gpu ? 1U : 0U); | ||
| #endif |
There was a problem hiding this comment.
Please drop changes from this file, too.
2 participants
No description provided.