-
Notifications
You must be signed in to change notification settings - Fork 117
Add unique, unique_copy and swap_ranges parallel range algorithms #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6ef1d07
to
3b9fa92
Compare
b02531f
to
25b1761
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked the signatures for their compliance with https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p3179r8.html#modify_copy - everything looks good.
a53327b
to
c0d749c
Compare
Minor comment: not all |
@MikeDvorskiy could you you please check and fix in this PR the issue #2283 ? |
22e0a8c
to
5987bc0
Compare
…type in __pattern_copy_if_ranges
…e auto return type in __pattern_copy_if_ranges
…e auto return type in __pattern_merge_ranges
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall it looks good to me.
ec90682
to
be968d1
Compare
…eview comment: re-implement works with range sizes in __pattern_swap + __hetero_tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable. A documentation note is needed about unique_copy
requiring sufficient output size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The details can be found in the links below.
Interface/Specification:
unique_copy
: [oneDPL] Add more copying mutating parallel range algorithms oneAPI-spec#635unique
,swap_ranges
: [oneDPL] Add more in-place mutating parallel range aglrithms oneAPI-spec#634RFC. It denotes the requirements and the rationale.