Skip to content

Conversation

MikeDvorskiy
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy commented May 20, 2025

The details can be found in the links below.

Interface/Specification:

RFC. It denotes the requirements and the rationale.

@MikeDvorskiy MikeDvorskiy marked this pull request as draft May 20, 2025 12:52
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/ranges_algo_L1-origin_UXL branch 8 times, most recently from 6ef1d07 to 3b9fa92 Compare May 20, 2025 14:03
@MikeDvorskiy MikeDvorskiy marked this pull request as ready for review May 21, 2025 15:45
@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/ranges_algo_L1-origin_UXL branch 2 times, most recently from b02531f to 25b1761 Compare May 23, 2025 15:53
Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've checked the signatures for their compliance with https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2025/p3179r8.html#modify_copy - everything looks good.

@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/ranges_algo_L1-origin_UXL branch from a53327b to c0d749c Compare May 27, 2025 13:53
SergeyKopienko

This comment was marked as outdated.

@SergeyKopienko
Copy link
Contributor

Minor comment: not all :: before std in changed lines has been removed.

@SergeyKopienko
Copy link
Contributor

@MikeDvorskiy could you you please check and fix in this PR the issue #2283 ?
Thanks.

@MikeDvorskiy MikeDvorskiy force-pushed the dev/mdvorski/ranges_algo_L1-origin_UXL branch 2 times, most recently from 22e0a8c to 5987bc0 Compare May 30, 2025 14:24
dmitriy-sobolev and others added 4 commits September 5, 2025 17:09
… - remove auto return type in __pattern_merge_ranges"

This reverts commit 6c8ae8d.
… - remove auto return type in __pattern_copy_if_ranges"

This reverts commit 5ed8e95.
… return type in __pattern_copy_if_ranges"

This reverts commit c5d5712.
Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me.

@SergeyKopienko SergeyKopienko force-pushed the dev/mdvorski/ranges_algo_L1-origin_UXL branch 3 times, most recently from ec90682 to be968d1 Compare September 6, 2025 09:47
Copy link
Contributor

@akukanov akukanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. A documentation note is needed about unique_copy requiring sufficient output size.

Copy link
Contributor

@SergeyKopienko SergeyKopienko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitriy-sobolev dmitriy-sobolev merged commit cdb0651 into main Sep 8, 2025
19 checks passed
@dmitriy-sobolev dmitriy-sobolev deleted the dev/mdvorski/ranges_algo_L1-origin_UXL branch September 8, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants