Open
Conversation
akukanov
requested review from
MikeDvorskiy,
SergeyKopienko,
danhoeflinger and
dmitriy-sobolev
akukanov
force-pushed
the
dev/remove-copy-ranges-akukanov
branch
from
92fc4ba to
89f312b
Compare
akukanov
force-pushed
the
dev/remove-copy-ranges-akukanov
branch
from
89f312b to
90f414c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of
ranges::remove_copy[_if]simply redirects tocopy_if, consistently with other variations of these algorithms in oneDPL. Bounded output is therefore supported "out of the box", with the same caveats as forcopy_if. The new tests are also based onstd_ranges_copy_if.pass, but extended with the data generator and with checker self-testing taken fromstd_ranges_unique_copy.passand adjusted as needed.