[RNG] add RNG armpl backend#634
Conversation
| add_subdirectory(rocrand) | ||
| endif() | ||
|
|
||
| if(ENABLE_ARMPL_BACKEND AND UNIX) |
There was a problem hiding this comment.
As it is only supported for Linux, should https://github.com/uxlfoundation/oneMath/blob/develop/cmake/FindARMPL.cmake (or other cmake files) handle the case when ENABLE_ARMPL_BACKEND is specified on Windows to have a clear error message on the configuration stage?
There was a problem hiding this comment.
I actually discovered recently that there is an ArmPl version available for Windows/Arm platform, so it may actually work. I don't think I'll be able to try the setup with oneMath anytime soon though, so I'm fine adding a message here.
andreyfe1
left a comment
andreyfe1
left a comment
There was a problem hiding this comment.
Thanks. Looks good to me overall
| @@ -0,0 +1,56 @@ | |||
| /******************************************************************************* | |||
| * Copyright 2025 SiPearl | |||
| * Copyright 2020-2021 Intel Corporation | |||
There was a problem hiding this comment.
Could you please clarify why the Intel's copyright is added?
There was a problem hiding this comment.
hello, most of these files have been duplicated from oneMKL backend, as implementation is roughly the same (OpenRNG from ArmPl is a drop-in replacement for Intel VSL, using same API. Some calls are not supported, others are added, so minor modifications were still necessary). So initial copyright was retained in these files. I can remove it if necessary, but I see this as derivative, so apache license says to retain them.
There was a problem hiding this comment.
ok. Let us take a closer look to determine whether this copyright is necessary or not
There was a problem hiding this comment.
We see no issues with that. Let's keep 2 copyrights in this and similar files
andreyfe1
left a comment
andreyfe1
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
4 participants
Description
Add RNG backend for ArmPl
OpenRNG from ARM, included in ArmPl, is a drop in replacement for OneMKL's VSL interface, most of the interface is the same. Some distributions are not yet implemented in OpenRNG (poisson lognormal).
4 tests (integer uniform with a<0 ) fail currently due to an issue in uniform generation for int32, reported to ARM. A check has been added to disable them pending next release
Checklist
All Submissions
log_rng.txt
100% tests passed, 0 tests failed out of 154
28 tests skipped