Skip to content

[cmake] update MKLConfig to 2025.1 release and gtest cmake version to 3.13#657

Merged
mkrainiuk merged 3 commits intouxlfoundation:developfrom
mkrainiuk:main
Apr 4, 2025
Merged

[cmake] update MKLConfig to 2025.1 release and gtest cmake version to 3.13#657
mkrainiuk merged 3 commits intouxlfoundation:developfrom
mkrainiuk:main

Conversation

@mkrainiuk
Copy link
Contributor

@mkrainiuk mkrainiuk commented Apr 2, 2025

Description

PR updates MKLConfig copy in this repo to the latest available one from Intel oneMKL 2025.1 release and updates oneMKL/Compiler versions to 2025.1 in PR CI workflow.

PR also updates min cmake version for googletest to 3.13 since the latest cmake from CI no longer supports anything < 3.5

Checklist

All Submissions

  • Do all unit tests pass locally?

Please note, generic BLAS failed because generic-sycl-components project uses too old cmake version. Not related to the changes from this PR

@mkrainiuk mkrainiuk requested a review from a team as a code owner April 2, 2025 23:02
@dnhsieh-intel
Copy link
Contributor

Thanks for the PR! Do we also need to update the workflow to 2025.1?

run: |
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/ac92f2bb-4818-4e53-a432-f8b34d502f23/intel-dpcpp-cpp-compiler-2025.0.0.740_offline.sh
sudo bash intel-dpcpp-cpp-compiler-2025.0.0.740_offline.sh -s -a -s --action install --eula accept
- name: Install Intel oneMKL
if: steps.domain_check.outputs.result == 'true'
run: |
wget --progress=dot:giga https://registrationcenter-download.intel.com/akdlm/IRC_NAS/79153e0f-74d7-45af-b8c2-258941adf58a/intel-onemkl-2025.0.0.940_offline.sh
sudo bash intel-onemkl-2025.0.0.940_offline.sh -s -a -s --action install --eula accept

Compiler URL: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/cd63be99-88b0-4981-bea1-2034fe17f5cf/intel-dpcpp-cpp-compiler-2025.1.0.573_offline.sh
MKL URL: https://registrationcenter-download.intel.com/akdlm/IRC_NAS/dc93af13-2b3f-40c3-a41b-2bc05a707a80/intel-onemkl-2025.1.0.803_offline.sh

@Rbiessy
Copy link
Contributor

Rbiessy commented Apr 3, 2025

Fixes #658

@mkrainiuk mkrainiuk force-pushed the main branch 2 times, most recently from 2aa1b15 to 2675b41 Compare April 3, 2025 19:04
@Rbiessy
Copy link
Contributor

Rbiessy commented Apr 4, 2025

FYI the generic SYCL BLAS CPU job is failing due to uxlfoundation/generic-sycl-components#7. We need to merge #655 to fix it. I meant to merge the 2 PRs at the same time but the CI jobs failed due to the cmake issue with the googletest dependency. I think we should add the changes from deps/googletest to the #655 and merge it first. @rafbiels are you ok to update that?

@rafbiels
Copy link
Contributor

rafbiels commented Apr 4, 2025

I think we should add the changes from deps/googletest to the #655 and merge it first. @rafbiels are you ok to update that?

I'd rather separate the fix into its own PR as it's unrelated, but I'm happy to work on this. However, I won't have time today, unfortunately. Let's take the discussion to #658

@Rbiessy
Copy link
Contributor

Rbiessy commented Apr 4, 2025

I'm also happy if we merge this PR first (despite the generic SYCL BLAS CI failing currently).

@mkrainiuk mkrainiuk changed the title [cmake] update MKLConfig to 2025.1 release [cmake] update MKLConfig to 2025.1 release and gtest cmake version to 3.13 Apr 4, 2025
@mkrainiuk mkrainiuk merged commit 13a2b34 into uxlfoundation:develop Apr 4, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants